Hi Martin!
Let's know how finished the coverity scan at: http://scan.coverity.com/
I can't find our OpenOffice.org there.
Also what is your opinion about OpenOffice.org++ project. One of memeber
has updated the patches for 2.2. Will someone review their patches. All
of them submited to Issuezilla.
Thanks,
KAMI
Martin Hollmichel írta:
Nikolai Pretzell wrote:
Martin Hollmichel schrieb:
> Nikolai talked some weeks ago about how helpful code reviews are
> (http://blogs.sun.com/GullFOSS/entry/code_reviews).
> [...]
> here:http://www.chipx86.com/blog/?p=222 or if people knows about other
> cool tools for doing reviews ?
Thank's, Martin, for bringing this up again.
In Hamburg we do such
(http://wiki.services.openoffice.org/wiki/Code_Reviews#Example:_Leightweight_Code_Reviews_within_OOo)
reviews for more than three month now, and there occurred a few
effects I like especially:
- the Coding Standards
(http://wiki.services.openoffice.org/wiki/Cpp_Coding_Standards) get
really fast "into the fingers", because we get in contact with them
each week,
- there appeared to be several things to be learned from the
co-developers, regarding as well their programming skills in general,
as their problem domain specifically,
- I get to know parts of the Office code, I never saw before, which
helps my understanding of the project as a whole.
After the current experience we would highly encourage any developer
in the OOo-community to try out such reviews, and even to make them a
regular habit.
Inspired by Joerg Jahnkes great page about regression tests
(http://wiki.services.openoffice.org/wiki/Steps_towards_regular_automated_regression_testing),
I set up a wiki page
http://wiki.services.openoffice.org/wiki/Steps_towards_regular_code_reviews
to focus the activities towards code reviews.
ok, we are talking here about two different aspects of code review,
the educational and the approval one. Both are quite important but
should treated in different ways. I think doing code review in the
public with the help of collaboration tools (webex, skype/voip,
http://cld.blog-city.com/netbeans_collaboration_project___collablets_and_codeaware_to.htm,
collab.netbeans.org) could be a major step forward getting new
developer into the project.
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
