Hi Frank, On Mon, 2008-02-11 at 15:00 +0100, Frank Schönheit - Sun Microsystems Germany wrote: > Sure. Again: The question is whether the gain is worth the pain. > Personally, I somehow doubt it.
I'm all for removing external header guards, and doing it in one step. The big gain I see is less confusion among external developers/contributors who do not have all the intimate details, agreements, rules about the codebase. When such a developer sees OO.o's codebase where headers are externally guarded in some places and not in others, he would get confused as to which convention to follow. Eliminating external guards entirely will also remove that confusion. Those who work on the codebase on a daily basis and communicate with each other every day may not be affected much, but there are others who don't have that luxury. Also, the benefit of removing ugliness from the codebase should not be underestimated IMO. Some people may not care all that much, but for others it is a big deal, and one that might determine whether or not he will contribute to the project. There is a pain of course, of syncing all the CWS'es, but it's just a one time pain, so I would not see it as a big roadblock, as long as someone else's doing the work. ;-) Kohei -- Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc. <[EMAIL PROTECTED]> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
