Frank Schönheit - Sun Microsystems Germany schrieb:
Hi Thorsten,

kendy and me now intend to execute the once-postponed plan to remove
external header guards (that #ifndef STUFF #include <STUFF> #endif
ugliness). A bit more background:
http://blog.thebehrens.net/2008/02/05/obsolete-external-header-guards/

We already discusses this a little bit by PM, so you know I have to ask
this here :)
What, except removing some "ugliness", which is alway highly subjective,
is the gain of this change?

Maintainability.

The "uglyness" IMHO is not subjective, and a defect. Maintainability is a major problem in any project as huge as OOo, so any improvement is helpful. The external header guards have two kinds of impact:
- unnecessary code,
- a potential cause for difficult to find errors, when internal include guards change.

I think we should welcome the opportunity that somebody is willing to do this work.

Nikolai

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to