Hi Malte, Malte Timmermann wrote:
> Hi Caolan, > > thanks for the updated list! :) > > I wonder: Who dares / volunteers to simply remove these methods? This is ongoing already. I have a CWS where the biggest chunks have been put in already (binfilter, filter, svtools, filter, desktop...). CWS is mba30patches01 and is still in QA. A warning to everyone committing such cleanups to cvs: please use "non-pro" builds on at least one platform (--enable-dbgutil in configure) as I found some cases where the stripped code only compiled for "pro" builds. Without a non-pro build I had broke the master for all developers using non-pro versions. Another interesting discovery was that removing ctors can be dangerous at times because some compilers automatically create default or copy ctors for classes even if they aren't used. If the corresponding ctor of the base class was removed, the build broke. Easiest fix for that was removing the classes completely as a class that isn't constructed surely also isn't really used, even if the methods are stilled called somewhere else in obviously also superfluous code. I found this problem mainly in "binfilter" - a fact that doesn't surprise a lot. I didn't find a pattern for when which compiler chose which class, I had broken builds on all platforms for different classes! Ciao, Mathias -- Mathias Bauer (mba) - Project Lead OpenOffice.org Writer OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't reply to "[EMAIL PROTECTED]". I use it for the OOo lists and only rarely read other mails sent to it. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
