Hi Andre,

thanks for an informative answer!

> 
> The reasons for the current solution are these:
> 
> 1. If I remember correctly the previews that are now part of the 
> document were planned but not really usable when I wrote the master page 
> controls.

Now I understand. I've already entered the issue about this:

http://qa.openoffice.org/issues/show_bug.cgi?id=94929
 
> 2. The previews in the template documents (from which the master pages 
> are taken) look differently from the previews used in the master page 
> controls.  The former do not show the placeholder shapes on the master 
> pages.  That is because the previews in the documents are made for the 
> first slide of the document not its master page.

OK. So probably we could solve this by simply moving the code for creating the 
thumbnail for the master page to the place where the thumbnail for the file is 
created, and solve the issue for template thumbnails and caching at the same 
time. The code could also rewrite thumbnails for templates created with OOo < 
3.1.
 
> 3. Using a persistent cache for storing the previews has its own set of 
> problems and, of course, has to be created from scratch.
> 
> 4. The current solution has the advantage that previews for the template 
> documents are created in the same way as the previews for master pages 
> that are in use by the current document: just render the master pages in 
> question.

There is another issue probably connected to caching the extension paths: if 
you uninstall the template extension and install it again, there will be no 
page previews as the paths are wrong (they point to the uninstalled extension). 
I will write the issue about this but I'm not sure to whom I should assign it.
 
> 
> None of the reasons above really prevents us from changing the current 
> behavior (which I am not happy with either).  The problem is not 
> technical either.  All of the technical problems mentioned above can be 
> solved.
> The main problems are a) coming up with a good solution and convince 
> people that it is better than the current state and b) get the time to 
> apply that solution.

I think I already have a); and b) should be quite easy, it's about moving the 
code and writing a simple test of the version of OOo that created the file.
 
> For me the time constraint is the most important but I would be happy to 
> give technical advice to anyone who wants to work on this.

Hm, I might give it a try as it seems pretty easy - but easy if you know 
*where* these parts are. I forgot my c++ as well, but I can still read it...

Best,
Marcin
 
> Best regards,
> 
> Andre
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to