pjfanning opened a new pull request, #22: URL: https://github.com/apache/openserverless-build/pull/22
Part of apache/openserverless#265. `OwSink.combine` in `openwhisk/common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/DockerToActivationFileLogStore.scala` says it is "basically copied from `Sink.combine`". Apache OpenWhisk added it in 2017 ([apache/openwhisk@d69f8db02](https://github.com/apache/openwhisk/commit/d69f8db02)), when it built against Akka 2.5.6. [Akka 2.5.6's `Sink.scala`](https://github.com/akka/akka/blob/v2.5.6/akka-stream/src/main/scala/akka/stream/scaladsl/Sink.scala) is Apache-2.0 and carries: ``` Copyright (C) 2014-2017 Lightbend Inc. <http://www.lightbend.com> ``` The file only had the ASF header. This PR keeps the ASF header and adds the upstream Lightbend notice below it: ```scala /* * OwSink.combine is derived from Sink.combine in Akka 2.5.6: * Copyright (C) 2014-2017 Lightbend Inc. <http://www.lightbend.com> */ ``` This follows the pattern `ConcurrentMapBackedCache.scala` already uses for the code it derives from Spray. Comment-only change. Akka 2.5.6 ships no `NOTICE` file, so nothing needs to be added to `NOTICE`. The matching entry in the top-level `LICENSE` of apache/openserverless is a separate PR. (apache/openserverless#265 has two errors. It gives the Akka version as 2.6.12, which is the version the build uses today, not the one the code was copied from. It also suggests re-deriving from Apache Pekko, but that would not help: Pekko's `Sink.scala` still carries the Lightbend copyright header, so the attribution would be needed either way.) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
