On Wed, Mar 09, 2011 at 01:19:02PM -0800, Ethan Jackson wrote:
> > Another approach, which had not occurred to me before now, would be to
> > use "true" as the default if a schema does not have any tables with
> > "isRoot" explicitly specified (for compatibility), and "false"
> > otherwise.  Do you like that better?  If you do, then I will implement
> > it that way instead.
> 
> If it's relatively easy to do that sounds like a good idea to me.  I'd
> prefer the default do the right thing if possible.  If it's too much
> work I wouldn't bother though, we can always change it later if it
> becomes a problem.  We don't add tables that often anyways.

It's not much work.

> > +    the <ref table="Open_vSwitch"/> table are automatically deleted
> > +    from the database, except for records in a few distinguished
> > +    ``root set'' tables noted below.
> > +  </p>
> 
> The diff looks good.  I made a minor comment about the wording of the
> above sentence which you may not have noticed:
> I would phrase this as "except for a few records in a distinguished"
> 
> I'm not married to that wording so if you think it's fine how it is
> just mention it.

Oh, I missed that part.

I don't understand why the "few" would be moved from "tables" to
"records".  Can you explain?
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to