Scattered throughout the code base we use long integers to
implement timers. When the result of timer_msec() is greater than
the time stored, we preform some action.
This commit creates a new timer library intended to replace these
manually managed timers. Code using the timer library will be more
obviously correct, and more consistent with other code using the
library.
---
lib/automake.mk | 2 +
lib/timer.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
lib/timer.h | 38 +++++++++++++++++++++++
3 files changed, 130 insertions(+), 0 deletions(-)
create mode 100644 lib/timer.c
create mode 100644 lib/timer.h
diff --git a/lib/automake.mk b/lib/automake.mk
index 297e89c..78a45ea 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -144,6 +144,8 @@ lib_libopenvswitch_a_SOURCES = \
lib/table.h \
lib/tag.c \
lib/tag.h \
+ lib/timer.c \
+ lib/timer.h \
lib/timeval.c \
lib/timeval.h \
lib/type-props.h \
diff --git a/lib/timer.c b/lib/timer.c
new file mode 100644
index 0000000..7e2759c
--- /dev/null
+++ b/lib/timer.c
@@ -0,0 +1,90 @@
+/*
+ * Copyright (c) 2011 Nicira Networks.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <config.h>
+
+#include "timer.h"
+
+#include "poll-loop.h"
+#include "timeval.h"
+
+/* Causes 'timer' to expire when 'duration' milliseconds have passed.
+ *
+ * May be used to initialize 'timer'. */
+void
+timer_set_duration(struct timer *timer, long long int duration)
+{
+ timer->t = time_msec() + duration;
+}
+
+/* Causes 'timer' never to expire.
+ *
+ * May be used to initialize 'timer'. */
+void
+timer_set_infinite(struct timer *timer)
+{
+ timer->t = LLONG_MAX;
+}
+
+/* Causes 'timer' to expire immediately.
+ *
+ * May be used to initialize 'timer'. */
+void
+timer_set_expired(struct timer *timer)
+{
+ timer->t = LLONG_MIN;
+}
+
+/* True if 'timer' has expired. */
+bool
+timer_expired(const struct timer *timer)
+{
+ return timer_expired_at(timer, time_msec());
+}
+
+/* True if 'timer' had (or will have) expired at 'time'. */
+bool
+timer_expired_at(const struct timer *timer, long long int time)
+{
+ return time >= timer->t;
+}
+
+/* Returns ture if 'timer' will never expire. */
+bool
+timer_is_infinite(const struct timer *timer)
+{
+ return timer->t == LLONG_MAX;
+}
+
+/* Returns the number of milliseconds until 'timer' expires. */
+long long int
+timer_msecs_until_expired(const struct timer *timer)
+{
+ switch (timer->t) {
+ case LLONG_MAX: return LLONG_MAX;
+ case LLONG_MIN: return 0;
+ default: return timer->t - time_msec();
+ }
+}
+
+/* Causes poll_block() to wake when 'timer' expires. */
+void
+timer_poll_wait(const struct timer *timer)
+{
+ if (timer->t < LLONG_MAX) {
+ poll_timer_wait_until(timer->t);
+ }
+}
diff --git a/lib/timer.h b/lib/timer.h
new file mode 100644
index 0000000..9d36432
--- /dev/null
+++ b/lib/timer.h
@@ -0,0 +1,38 @@
+/*
+ * Copyright (c) 2011 Nicira Networks.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef TIMER_H
+#define TIMER_H 1
+
+#include <stdbool.h>
+
+struct timer {
+ long long int t;
+};
+
+void timer_set_duration(struct timer *, long long int duration);
+void timer_set_infinite(struct timer *);
+void timer_set_expired(struct timer *);
+
+bool timer_expired(const struct timer *);
+bool timer_expired_at(const struct timer *timer, long long int time);
+bool timer_is_infinite(const struct timer *);
+
+long long int timer_msecs_until_expired(const struct timer *);
+
+void timer_poll_wait(const struct timer *);
+
+#endif /* timer.h */
--
1.7.4.2
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
