On Thu, Mar 31, 2011 at 03:12:18PM -0700, Ethan Jackson wrote: > Scattered throughout the code base we use long integers to > implement timers. When the result of timer_msec() is greater than > the time stored, we preform some action. > > This commit creates a new timer library intended to replace these > manually managed timers. Code using the timer library will be more > obviously correct, and more consistent with other code using the > library.
Seems OK to me. I do have a few minor comments. I'd s/timer_poll_wait/timer_wait/ since that seems more conventional in our code base. I'd consider inlining many of the functions into the header file since they are so trivial that it is likely to actually reduce code size. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
