Before commit 3f19d399f "datapath: Fix mysterious GRE-over-IPSEC problems," 'packet' in opd_packet_cmd_execute() was an skb cloned from one created by Netlink, so its cb member wasn't necessarily zeroed. But that commit changed 'packet' to be freshly allocated with __dev_alloc_skb(), which means that cb is zeroed, so we don't have to do it again.
Signed-off-by: Ben Pfaff <[email protected]> --- datapath/datapath.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 5ce77cd..20ae4d8 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -714,9 +714,6 @@ static int odp_packet_cmd_execute(struct sk_buff *skb, struct genl_info *info) else packet->protocol = htons(ETH_P_802_2); - /* Initialize OVS_CB (it came from Netlink so might not be zeroed). */ - memset(OVS_CB(packet), 0, sizeof(struct ovs_skb_cb)); - err = flow_extract(packet, -1, &key, &is_frag); if (err) goto err_kfree_skb; -- 1.7.4.4 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
