On Fri, Apr 29, 2011 at 10:45:58AM -0700, Jesse Gross wrote: > On Fri, Apr 29, 2011 at 10:07 AM, Ben Pfaff <[email protected]> wrote: > > It's (almost) always easier to understand a function with fewer parameters, > > so this removes the now-redundant sw_flow_key and actions parameters from > > execute_actions(), since they can be found through OVS_CB(skb)->flow now. > > > > This also necessarily moves loop detection into execute_actions(). > > Otherwise, the flow's actions could have changed between the time that the > > loop was detected and the time that it was suppressed, which would mean > > that the wrong (version of the) flow would get suppressed. > > > > Signed-off-by: Ben Pfaff <[email protected]> > > I see an extra blank line before the call to execute_actions() in > dp_process_received_packet() but otherwise: > > Acked-by: Jesse Gross <[email protected]>
Thanks. I deleted the blank lines and the "Execute actions." comment too. I pushed these to master. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
