On Wed, Jun 01, 2011 at 01:38:17PM -0700, Jean Tourrilhes wrote:
> On Wed, Jun 01, 2011 at 09:34:22AM -0700, Ben Pfaff wrote:
> > FWW_NW_TOS and some other L3 fields weren't wildcarded, but should have
> > been. It's better to start with all fields wildcarded and then unwildcard
> > the ones that shouldn't be.
>
> Problems :
> 1) By default, the controller does not start in exact match
> mode, flows are always wildcarded, and there is no way to set matching
> to exact match.
Why do you say this? I believe that my patch preserves the current
behavior of exact match mode. It should only change the behavior of
wildcard mode.
Here is what the code looks like post-patch:
if (!cfg->exact_flows) {
/* We cannot wildcard all fields.
* We need in_port to detect moves.
* We need both SA and DA to do learning. */
flow_wildcards_init_catchall(&sw->wc);
sw->wc.wildcards &= ~(FWW_IN_PORT | FWW_DL_SRC | FWW_DL_DST
| FWW_ETH_MCAST);
sw->wc.vlan_tci_mask = htons(VLAN_CFI | VLAN_VID_MASK);
} else {
flow_wildcards_init_exact(&sw->wc);
}
> 2) Still has normalisation errors :
I'm afraid that I don't see those with the patch I posted applied to
"branch-1.1" currently available from openvswitch.org. I don't know
why we are seeing different results.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
