On Wed, Jun 01, 2011 at 01:59:50PM -0700, Ben Pfaff wrote:
> On Wed, Jun 01, 2011 at 01:38:17PM -0700, Jean Tourrilhes wrote:
> > On Wed, Jun 01, 2011 at 09:34:22AM -0700, Ben Pfaff wrote:
> > > FWW_NW_TOS and some other L3 fields weren't wildcarded, but should have
> > > been. It's better to start with all fields wildcarded and then unwildcard
> > > the ones that shouldn't be.
> >
> > Problems :
> > 1) By default, the controller does not start in exact match
> > mode, flows are always wildcarded, and there is no way to set matching
> > to exact match.
>
> Why do you say this?
On the 1.1.0 branch, the fix to properly set exact_flows in
the config is not done. The patch need to be done in
ovs-controller.c... Maybe that's a separate patch, but don't forget
about it ;-)
> I believe that my patch preserves the current behavior of exact
> match mode.
Yes, but currently on 1.1.0 there is no way to set exact match
mode.
> > 2) Still has normalisation errors :
>
> I'm afraid that I don't see those with the patch I posted applied to
> "branch-1.1" currently available from openvswitch.org. I don't know
> why we are seeing different results.
I don't know either. Note that I'm using the 1.1.0 tarball, so
maybe the difference is a patch that happened since 1.1.0.
Note that something has changed. The original normalisation
warning was :
-------------------------------------------------
Jun 01 16:22:41|00080|ofp_util|INFO| pre: wildcards= 0x820f0 in_port= 1
dl_src=00:07:e9:09:3c:fd dl_dst=00:60:b0:ce:2d:d9 dl_vlan=65535 dl_vlan_pcp=
0 dl_type= 0 nw_tos= 0 nw_proto= 0 nw_src= 0 nw_dst=
0 tp_src= 0 tp_dst= 0
Jun 01 16:22:41|00081|ofp_util|INFO|post: wildcards= 0x2ffff0 in_port= 1
dl_src=00:07:e9:09:3c:fd dl_dst=00:60:b0:ce:2d:d9 dl_vlan=65535 dl_vlan_pcp=
0 dl_type= 0 nw_tos= 0 nw_proto= 0 nw_src= 0 nw_dst=
0 tp_src= 0 tp_dst= 0
-------------------------------------------------
Whereas with your patch, it has become :
-------------------------------------------------
Jun 01 13:30:38|00042|ofp_util|INFO| pre: wildcards= 0x2820f0 in_port= 1
dl_src=20:fd:f1:71:e3:99 dl_dst=01:80:c2:00:00:0a dl_vlan=65535 dl_vlan_pcp=
0 dl_type= 0 nw_tos= 0 nw_proto= 0 nw_src= 0 nw_dst=
0 tp_src= 0 tp_dst= 0
Jun 01 13:30:38|00043|ofp_util|INFO|post: wildcards= 0x2ffff0 in_port= 1
dl_src=20:fd:f1:71:e3:99 dl_dst=01:80:c2:00:00:0a dl_vlan=65535 dl_vlan_pcp=
0 dl_type= 0 nw_tos= 0 nw_proto= 0 nw_src= 0 nw_dst=
0 tp_src= 0 tp_dst= 0
-------------------------------------------------
Regards,
Jean
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
