> It sounds right.  Have you tested it?

I've done no testing on this patch.  It seems fairly low risk to me,
I'd be inclined to let the system testing we already have cover it.

> The comment just above "if (bond->lacp_negotiated) {" should probably
> be updated.

Changed to the following:

    /* LACP bonds have very loose admissibility restrictions because we can
     * assume the remote switch is aware of the bond and will "do the right
     * thing".  However, as a precaution we drop packets on disabled slaves
     * because no correctly implemented partner switch should be sending
     * packets to them. */

Ethan.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to