On Mon, Jul 25, 2011 at 02:43:12PM -0700, Ethan Jackson wrote:
> > + ? ? ?% ovsdb-server --remote=punix:/usr/local/var/run/openvswitch/db.sock
> > \
> > + ? ? ? ? ? ? ? ? ? ? --remote=db:Open_vSwitch,manager_options \
> > + ? ? ? ? ? ? ? ? ? ? --private-key=db:SSL,private_key \
> > + ? ? ? ? ? ? ? ? ? ? --certificate=db:SSL,certificate \
> > + ? ? ? ? ? ? ? ? ? ? --bootstrap-ca-cert=db:SSL,ca_cert \
> > + ? ? ? ? ? ? ? ? ? ? --pidfile --detach
>
> I'm not sure I would call this command "easy" even without the
> explicit database location =).
OK, s/easy/easier/.
> > @@ -738,14 +739,19 @@ parse_options(int argc, char *argv[], char
> > **file_namep,
> > ? ? argc -= optind;
> > ? ? argv += optind;
> >
> > - ? ?if (argc > 1) {
> > + ? ?switch (argc) {
> > + ? ?case 0:
> > + ? ? ? ?*file_namep = xasprintf("%s/openvswitch/conf.db",
> > ovs_sysconfdir());
> > + ? ? ? ?break;
> > +
> > + ? ?case 1:
> > + ? ? ? ?*file_namep = argv[0];
>
> I wonder if we should xsturdup(argv[0]) here. That way file_namep
> would always be heap allocated and we can free it after we've opened
> the database. Doesn't really matter, but it might make valgrind
> happier.
Might as well. I made that change.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
