>
>> + cancel_delayed_work_sync(&cache_cleaner_wq);
>
> This should have been stopped when the last port is removed, right?
>
I did it as it can cancel cache clearer in case of bug related port not deleted.
>> + for (i = 0; i < PORT_TABLE_SIZE; i++) {
>> + hash_head = &port_table[i];
>> + hlist_for_each_entry_safe(tnl_vport, pos, n, hash_head,
>> + hash_node) {
>
> It's not actually necessary to use the _safe variant since nothing is
> getting removed by it. I also noticed that you have a tendency to
> declare variables at beginning of the function instead of the closest
> scoped region (in this case the for loop), which is generally
> preferred.
>
ok,
I will fix patch according to comments.
Thanks,
Pravin.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
