On Fri, Sep 9, 2011 at 2:34 PM, Pravin Shelar <[email protected]> wrote: >> >>> + cancel_delayed_work_sync(&cache_cleaner_wq); >> >> This should have been stopped when the last port is removed, right? >> > I did it as it can cancel cache clearer in case of bug related port not > deleted.
It seems like there is a lot of stuff going into the case where ports aren't deleted, which should never happen. If it did happen then it would affect other types of ports as well, not just tunnels so it seems a little odd. To be honest, I'm somewhat tempted to just drop the entire check just do the freeing of the array in this function but since it's not performance critical in any way I don't feel that strongly. When you're done with the changes, go ahead and push it. You can add my acked-by: Acked-by: Jesse Gross <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
