On Tue, Jan 31, 2012 at 01:26:50PM -0800, Ben Pfaff wrote:
> On Tue, Jan 31, 2012 at 01:21:40PM -0800, Gurucharan Shetty wrote:
> My apologies. But, regardless, I just noticed that
> if [ "${OVSBOOTPROTO}" = "dhcp" -a -n "${OVSINTF}" ]; then
> should really be written as
> if [ "${OVSBOOTPROTO}" = "dhcp" ] && [ -n "${OVSINTF}" ]; then
> for safety. As POSIX says:
First variant is safe because of "-n":$ sh -c '[ "foo" = foo -a "!" ]; echo $?' sh: line 0: [: argument expected 2 $ sh -c '[ "foo" = foo -a -n "!" ]; echo $?' 0 -- Regards, -- Sir Raorn. --- http://thousandsofhate.blogspot.com/
signature.asc
Description: Digital signature
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
