On Wed, Feb 01, 2012 at 02:31:39AM +0400, Alexey I. Froloff wrote:
> On Tue, Jan 31, 2012 at 01:26:50PM -0800, Ben Pfaff wrote:
> > On Tue, Jan 31, 2012 at 01:21:40PM -0800, Gurucharan Shetty wrote:
> > My apologies. But, regardless, I just noticed that
> > if [ "${OVSBOOTPROTO}" = "dhcp" -a -n "${OVSINTF}" ]; then
> > should really be written as
> > if [ "${OVSBOOTPROTO}" = "dhcp" ] && [ -n "${OVSINTF}" ]; then
> > for safety. As POSIX says:
> First variant is safe because of "-n":
It's best, IMO, to always avoid -a and -o. It's always safe to use &&
and || instead.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
