Justin, thanks for the review, which I can see at
http://openvswitch.org/pipermail/dev/2012-April/016863.html
even though it never made it to my email inbox.
Justin writes:
> On Apr 26, 2012, at 4:04 PM, Ben Pfaff wrote:
>
> > +The provided bytes will be padded on the right by enough bytes with
> > +value 0 to make the total number 6 more than a multiple of 8.
>
> I think it might help to provide a brief explanation of why that
> happens. How about something like the following?
>
> "Due to the way the note action is structured, the provided bytes…"
I changed the text to:
The \fBnote\fR action's format doesn't include an exact length for its
payload, so the provided bytes will be padded on the right by enough
bytes with value 0 to make the total number 6 more than a multiple of
8.
and pushed this to master.
On Thu, Apr 26, 2012 at 04:04:26PM -0700, Ben Pfaff wrote:
> Reported-by: Paul Ingram <[email protected]>
> Signed-off-by: Ben Pfaff <[email protected]>
> ---
> utilities/ovs-ofctl.8.in | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
> index d1d82c5..1b364dc 100644
> --- a/utilities/ovs-ofctl.8.in
> +++ b/utilities/ovs-ofctl.8.in
> @@ -886,6 +886,8 @@ processing.
> Does nothing at all. Any number of bytes represented as hex digits
> \fIhh\fR may be included. Pairs of hex digits may be separated by
> periods for readability.
> +The provided bytes will be padded on the right by enough bytes with
> +value 0 to make the total number 6 more than a multiple of 8.
> .
> .IP
> "\fBmove:\fIsrc\fB[\fIstart\fB..\fIend\fB]\->\fIdst\fB[\fIstart\fB..\fIend\fB]\fR"
> Copies the named bits from field \fIsrc\fR to field \fIdst\fR.
> --
> 1.7.2.5
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
