On Jun 14, 2012, at 3:59 PM, Ben Pfaff wrote:
> forward_bpdu_changed(struct ofproto *ofproto_)
> {
> struct ofproto_dpif *ofproto = ofproto_dpif_cast(ofproto_);
> - /* Revalidate cached flows whenever forward_bpdu option changes. */
> - ofproto->need_revalidate = true;
> +
> + ofproto->need_revalidate = REV_RECONFIGURE;
> }
If you want to make it similar to the other functions in that part of the file,
you could leave out the blank line.
Setting the "need_revalidate" to false now looks a little odd. It might be
nice to either define an enum for that, or at least document the behavior in
the enum definition.
I didn't check this, but is it possible that one thing that causes a revalidate
would always trigger another? For example, if a REV_PORT_TOGGLED always ended
up triggering a REV_RECONFIGURE down the line, then you might never see the
REV_PORT_TOGGLED, since it's just an enum. As I said, I don't know that this
could actually occur.
Otherwise, it looks good to me.
--Justin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
