On Jun 21, 2012, at 8:34 AM, Ben Pfaff wrote:

> On Thu, Jun 21, 2012 at 08:27:11AM -0700, Ben Pfaff wrote:
>> On Wed, Jun 20, 2012 at 08:44:01PM -0700, Justin Pettit wrote:
>>> Setting the "need_revalidate" to false now looks a little odd.  It
>>> might be nice to either define an enum for that, or at least document
>>> the behavior in the enum definition.
>> 
>> I added a paragraph to the enum comment:
>> 
>> * A value of 0 means that there is no need to revalidate.
>> 
>> Is that good?
> 
> Oh, and I changed "false" to "0" in the places where we set
> need_revalidate.  Maybe that is clearer now.


All of your feedback made sense to me.  Thanks.

--Justin


_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to