On Thu, Oct 18, 2012 at 07:16:24PM -0700, Ethan Jackson wrote: > log_poll_interval() is a little bit too aggressive, and is > therefore less useful than it could be. This patch removes the > mean interval calculation, and simply logs if the poll loop took > longer than 1 second instead. > > Signed-off-by: Ethan Jackson <[email protected]> > --- > > Note to the reviewer: > > I personally am a bit skeptical of the mean interval calculation, but I may be > wrong on this point. I can add it back if necessary. Also most of this patch > is whitespace changes, it's easiest to review with the -w option.
All of it seems fine. I'm unsure of the rationale for the new criteria for coverage logging. Off-hand, I would have just logged it whenever we print the "unreasonably long poll interval" message. Any particular reason for the 100 ms criteria there? _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
