On Thu, Oct 18, 2012 at 3:03 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Thu, Oct 18, 2012 at 02:57:52PM -0700, Pravin Shelar wrote:
>> On Thu, Oct 18, 2012 at 2:51 PM, Ben Pfaff <b...@nicira.com> wrote:
>> > In the changes, I see only a couple little style things.
>> >
>> > In ovs_flow_from_nlattrs(), I see a couple of places where sizeof and
>> > its operand have a space between them. Kernel style frowns on that.
>> >
>> > In gre_update_header,
>> > } else if (out_key ||
>> > tunnel_type & TNL_T_PROTO_GRE64) {
>> > could be written as one line.
>> >
>> ok, I will fix code accordingly.
>
> OK.
>
> (Personally, I don't feel a need to re-review it.)
Thanks Ben, Jesse and Kyle, I pushed this series to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
