On Sat, Oct 20, 2012 at 3:36 PM, Kyle Mestery (kmestery) <[email protected]> wrote: > On Oct 20, 2012, at 2:36 PM, Pravin Shelar <[email protected]> wrote: >> On Thu, Oct 18, 2012 at 3:03 PM, Ben Pfaff <[email protected]> wrote: >>> On Thu, Oct 18, 2012 at 02:57:52PM -0700, Pravin Shelar wrote: >>>> On Thu, Oct 18, 2012 at 2:51 PM, Ben Pfaff <[email protected]> wrote: >>>>> In the changes, I see only a couple little style things. >>>>> >>>>> In ovs_flow_from_nlattrs(), I see a couple of places where sizeof and >>>>> its operand have a space between them. Kernel style frowns on that. >>>>> >>>>> In gre_update_header, >>>>> } else if (out_key || >>>>> tunnel_type & TNL_T_PROTO_GRE64) { >>>>> could be written as one line. >>>>> >>>> ok, I will fix code accordingly. >>> >>> OK. >>> >>> (Personally, I don't feel a need to re-review it.) >> >> Thanks Ben, Jesse and Kyle, I pushed this series to master. > > Thanks Pravin! I didn't see any email to the git mailing list indicating it > was pushed, > though. Just checked the archives online as well and didn't see it. Just FYI. >
For some reason commits are not pushed to openvswitch.org repo, Let me check why it is not working. Thanks, Pravin. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
