On Mon, Oct 14, 2013 at 03:57:34PM -0700, Jarno Rajahalme wrote:
> Sets mask bits for the given field and its prerequisite fields.
> Needed for later patches.
> 
> Signed-off-by: Jarno Rajahalme <[email protected]>

I find the purpose of the new mf_force_prereqs() function really
mysterious.  The reason for not setting mask->dl_type is the most
mysterious part.  I hope the upcoming patch will make it clear.

exact_match_mask is only used in mf_force_prereqs(), so I guess it might
as well be local to that function.

MFP_VLAN_VID constrain dl_type, but it's included in the case where that
constraint would be if it were not commented out.

This can use IN6ADDR_EXACT_INIT:
> +#define MF_EXACT_MASK_INITIALIZER { { { { ~0, ~0, ~0, ~0,  ~0, ~0, ~0, ~0, \
> +                        ~0, ~0, ~0, ~0,  ~0, ~0, ~0, ~0 } } } }
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to