On Oct 15, 2013, at 8:46 AM, Ben Pfaff <[email protected]> wrote:
> On Mon, Oct 14, 2013 at 03:57:34PM -0700, Jarno Rajahalme wrote:
>> Sets mask bits for the given field and its prerequisite fields.
>> Needed for later patches.
>>
>> Signed-off-by: Jarno Rajahalme <[email protected]>
>
> I find the purpose of the new mf_force_prereqs() function really
> mysterious. The reason for not setting mask->dl_type is the most
> mysterious part. I hope the upcoming patch will make it clear.
>
Sorry for not making this clearer. And the most mysterious part is really a
stupid optimization, since where the function is used, the dl_type is always
already set.
> exact_match_mask is only used in mf_force_prereqs(), so I guess it might
> as well be local to that function.
OK.
>
> MFP_VLAN_VID constrain dl_type, but it's included in the case where that
> constraint would be if it were not commented out.
>
I will uncomment the dl_type masking to make this function clearer.
> This can use IN6ADDR_EXACT_INIT:
>> +#define MF_EXACT_MASK_INITIALIZER { { { { ~0, ~0, ~0, ~0, ~0, ~0, ~0, ~0, \
>> + ~0, ~0, ~0, ~0, ~0, ~0, ~0, ~0 } } } }
Thanks, didn't know about IN6ADDR_EXACT_INIT.
Jarno
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
