On Wed, Mar 19, 2014 at 12:32:22PM -0700, Ben Pfaff wrote:
> On Tue, Mar 18, 2014 at 01:54:09PM -0700, Pravin wrote:
> > DPDK need to set _lcore_id for using multiple core.
> > 
> > Signed-off-by: Pravin B Shelar <[email protected]>
> 
> In xpthread_setaffinity_np_cpu(), I think that the whole function is
> Linux-specific, so that the implementation should be enclosed in
> #ifdef __linux__.  I'd also encourage you to add a comment explaining
> what it does to make it easier to provide an implementation on other
> OSes.

Oh, also xpthread_setaffinity_np_cpu() doesn't actually use its
'thread' argument.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to