On Wed, Mar 19, 2014 at 03:01:09PM -0700, Pravin Shelar wrote:
> On Wed, Mar 19, 2014 at 12:32 PM, Ben Pfaff <[email protected]> wrote:
> > On Tue, Mar 18, 2014 at 01:54:09PM -0700, Pravin wrote:
> >> DPDK need to set _lcore_id for using multiple core.
> >>
> >> Signed-off-by: Pravin B Shelar <[email protected]>
> >
> > In xpthread_setaffinity_np_cpu(), I think that the whole function is
> > Linux-specific, so that the implementation should be enclosed in
> > #ifdef __linux__.  I'd also encourage you to add a comment explaining
> > what it does to make it easier to provide an implementation on other
> > OSes.
> 
> For now I will move this API to dpif-netdev. I do not see it getting
> used in other parts of vswitchd in near future.

Just as good, thanks.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to