Hi Nithin, Perhaps, it would be better to have the check for gOvsSwitchContext much earlier at the Dispatcher function and avoid this check in ValidateNetlinkCmd() and in every handler function as well. Thanks, Eitan
-----Original Message----- From: dev [mailto:[email protected]] On Behalf Of Nithin Raju Sent: Wednesday, October 15, 2014 11:31 AM To: [email protected] Subject: [ovs-dev] [PATCH] datapath-windows: check for 'gOvsSwitchContext' in ValidateNetlinkCmd() Signed-off-by: Nithin Raju <[email protected]> --- datapath-windows/ovsext/Datapath.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index 6c78ab8..50ea2ff 100644 --- a/datapath-windows/ovsext/Datapath.c +++ b/datapath-windows/ovsext/Datapath.c @@ -855,8 +855,8 @@ ValidateNetlinkCmd(UINT32 devOp, /* Validate the DP for commands that require a DP. */ if (nlFamilyOps->cmds[i].validateDpIndex == TRUE) { OvsAcquireCtrlLock(); - if (ovsMsg->ovsHdr.dp_ifindex != - (INT)gOvsSwitchContext->dpNo) { + if (!gOvsSwitchContext || ovsMsg->ovsHdr.dp_ifindex != + (INT)gOvsSwitchContext->dpNo) { status = STATUS_INVALID_PARAMETER; OvsReleaseCtrlLock(); goto done; -- 1.7.4.1 _______________________________________________ dev mailing list [email protected] https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=yTvML8OxA42Jb6ViHe7fUXbvPVOYDPVq87w43doxtlY%3D%0A&m=He3WDWO5kRH2eWyqsCeS6aZeydn8bjTQG16YaqHpnxg%3D%0A&s=2ec1b070ecf6c099b3faa223be81fe66f2f173db73371a39488fec72ee96aac3 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
