Acked-by: Eitan Eliahu <[email protected]>

(we check for gOvsSwitchContext in each of the handlers so this check should be 
removed and the user mode interface should be enabled only after the extension 
is activated, will be addressed soon)
Thanks,
Eitan

-----Original Message-----
From: Nithin Raju 
Sent: Thursday, October 23, 2014 8:47 AM
To: Eitan Eliahu
Cc: [email protected]
Subject: Re: [ovs-dev] [PATCH] datapath-windows: check for 'gOvsSwitchContext' 
in ValidateNetlinkCmd()

On Oct 15, 2014, at 10:08 PM, Eitan Eliahu <[email protected]> wrote:

> 
> Nithin, the DP commands are an exception. But, it does not make sense to 
> check if the driver got initialized in each of the handlers.
> One simple way to handle the exception is to condition it by the Family ID 
> (not DP).

>From your comment above and from the IRC discussion, it seems that you are not 
>happy with checking for 'gOvsSwitchContext' in each of the functions. I agree 
>with you. Since Alin is looking into cleaning up the code for usage of 
>'gOvsSwitchContext' overall, can you pls. ACK this particular patch, if it 
>looks OK? The patch specifically fixes the issue of a kernel crash if you run 
>ovs-dpctl/ovs-vswitchd without enabling OVS extension on the Hyper-V switch.

thanks,
-- Nithin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to