On Wed, Oct 22, 2014 at 2:23 PM, Ben Pfaff <[email protected]> wrote: > On Wed, Oct 22, 2014 at 02:18:41PM -0700, Andy Zhou wrote: >> OVS userspace are backword compatible with older Linux kernel modules. >> However, not having the most up-to-date datapath kernel modules can >> some times lead to user confusion. Storing the datapath version in >> OVSDB allows management software to check and optionally provide >> notifications to users. >> >> Signed-off-by: Andy Zhou <[email protected]> > > Thanks for the patch. I have a few comments. > > I think that each datapath should be able to report its own version, > that is, I think that this should be part of the dpif_*() interfaces > that call into some function defined in struct dpif_class. I don't > think it is a good idea to make bridge.c Linux-specific.
Thanks for review. I will re-spin the patch. > > There are many fields in the database that we set every time, without > bothering to check whether we've already set it. The OVSDB interface > library should be pretty good at "optimizing out" these redundant set > operations. So, I would not bother keeping track of whether we've > already set the datapath information (with the 'embryonic' variable). Will do. > > Thanks, > > Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
