On Wed, Oct 22, 2014 at 2:50 PM, Justin Pettit <[email protected]> wrote:
>
>> On Oct 22, 2014, at 2:18 PM, Andy Zhou <[email protected]> wrote:
>
> In addition to what Ben said, here are a few other things.
>
>> + /* Set true when created. Reset to false after the datpath
>
> Datapath is mispelled.
Will fix in the next re-spin.
>
>> +static void
>> +init_ovs_version(const char *version)
>> +{
>> + if (ovs_version) {
>> + free_ovs_version();
>> + }
>> +
>> + ovs_version = xstrdup(version ? version : VERSION);
>
> In the case of the built-in kernel module, isn't this going to return VERSION
> which is the OVS version number?
I have revised the logic. VERSION will not be referenced any more,
ovs_version will always reflect what's stored in OVSDB.
>
>> + /* For "system" type datapath, record the Linux kenrel modules'
>> + * verions number. Other datapath types are assumed to be supplied
>> + * by openvswitch itself, thus inherit the same version string. */
>
> Kernel is misspelled.
Yes, it is. The code is removed in rev2, so is the comment.
>
>> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
>> index d90f221..0af0637 100644
>> --- a/vswitchd/vswitch.xml
>> +++ b/vswitchd/vswitch.xml
>> @@ -582,6 +582,11 @@
>> column="other-config" key="datapath-id"/> instead.)
>> </column>
>>
>> + <column name="datapath_version">
>> + Reports the OpenFlow datapath version in use. Can be empty if
>> + datapath version can not be determined.
>> + </column>
>
> I believe this should be "Open vSwitch" and not "OpenFlow".
This is the same expression as datapath_id. Should that be changed as well?
>
> --Justin
>
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
