On Fri, Oct 24, 2014 at 3:16 PM, Thomas Graf <tg...@noironetworks.com> wrote:
> On 10/24/14 at 12:23pm, Pravin Shelar wrote:
>> >> * enum ovs_action_attr - Action types.
>> >> *
>> >> @@ -633,6 +642,10 @@ enum ovs_action_attr {
>> >> * data immediately followed by a
>> >> mask.
>> >> * The data must be zero for the
>> >> unmasked
>> >> * bits. */
>> >> +#ifndef __KERNEL__
>> >> + OVS_ACTION_ATTR_TUNNEL_PUSH,
>> >> + OVS_ACTION_ATTR_TUNNEL_POP,
>> >> +#endif
>> >> __OVS_ACTION_ATTR_MAX
>> >> };
>> >
>> > Should we remove the #ifndef so the action values are reserved in the
>> > kernel datapath as well? We don't want conflicting actions types later on.
>> >
>> There is no plan for implementing this action for kernel datapath, so
>> for now I do not want to reserve number for the action.
>
> Let me try to rephrase. The next kernel action to be added can't reuse
> the space so you have to reserve the new IDs in the kernel context as
> well. The easiest way seems to be to just remove the #ifndef but not
> implement the actions.
I want OVS_ACTION_ATTR_MAX consistent for kernel and userspace, So
that datapath can validate actions. I will add comment to keep these
actions at the end of enum so that action id do not change in
userspace and kernel.
We can not reserve any IDs for userspace only actions since we can not
upstream it.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
