Eitan, Like we discussed offline, I am not comfortable with a netlink call waiting on another thread in a synchronous context. For what it is worth, all the calls from userspace to kernel are non-blocking. It would be great if we can not have a separate thread, and instead use some primitives such as atomic variables to synchronize between the WFP calls. We can talk more during the IRC meeting.
thanks, -- Nithin > On Jan 26, 2015, at 1:34 PM, Eitan Eliahu <[email protected]> wrote: > > > Hi Sorin, > Thank you for addressing these issues. Please find some minor comments below. > The issue I see now is that the IOCTL completion is not synchronized with the > engine execution and if the transaction fails it is not propagated to user > mode . I realize that the thread exists when the transaction fails but we > might just fail the transaction. > I think once we have the IOCTL synced we can go ahead with this challenging > change. > Eitan _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
