Looks good. Thanks. Acked-by: Justin Pettit <jpet...@nicira.com>
--Justin > On Apr 20, 2015, at 2:47 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Mon, Apr 20, 2015 at 02:33:00PM -0700, Justin Pettit wrote: >> >>> On Apr 18, 2015, at 10:04 AM, Ben Pfaff <b...@nicira.com> wrote: >>> >>> + <column name="logical_datapath"> >>> + The logical datapath to which the logical port belongs. A logical >>> + datapath implements a logical pipeline among the ports in the <ref >>> + table="Bindings"/> table associated with it. (No table represents a >>> + logical datapath.) >>> + </column> >> >> I agree with Russell's feedback. In addition, a datapath, in OVS >> terminology, has historically been a switch, but now we're including >> routers, so it feels like we're broadening the term. I think >> another sentence here and the architecture document describing a >> logical datapath would be useful. > > Fair enough, I folded this in: > > diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml > index 9ed162b..ef5e5f4 100644 > --- a/ovn/ovn-architecture.7.xml > +++ b/ovn/ovn-architecture.7.xml > @@ -254,6 +254,38 @@ > another name may be used. > </p> > > + <h2>Logical Networks</h2> > + > + <p> > + A <dfn>logical network</dfn> implements the same concepts as physical > + networks, but they are insulated from the physical network with tunnels > or > + other encapsulations. This allows logical networks to have separate IP > and > + other address spaces that overlap, without conflicting, with those used > for > + physical networks. Logical network topologies can be arranged without > + regard for the topologies of the physical networks on which they run. > + </p> > + > + <p> > + Logical network concepts in OVN include: > + </p> > + > + <ul> > + <li> > + <dfn>Logical switches</dfn>, the logical version of Ethernet switches. > + </li> > + > + <li> > + <dfn>Logical routers</dfn>, the logical version of IP routers. Logical > + switches and routers can be connected into sophisticated topologies. > + </li> > + > + <li> > + <dfn>Logical datapaths</dfn> are the logical version of an OpenFlow > + switch. Logical switches and routers are both implemented as logical > + datapaths. > + </li> > + </ul> > + > <h2>Life Cycle of a VIF</h2> > > <p> > diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml > index 99c809a..c623cff 100644 > --- a/ovn/ovn-sb.xml > +++ b/ovn/ovn-sb.xml > @@ -231,7 +231,10 @@ > The logical datapath to which the logical port belongs. A logical > datapath implements a logical pipeline among the ports in the <ref > table="Bindings"/> table associated with it. (No table represents a > - logical datapath.) > + logical datapath.) In practice, the pipeline in a given logical > datapath > + implements either a logical switch or a logical router, and > + <code>ovn-northd</code> reuses the UUIDs for those logical entities > from > + the <code>OVN_Northbound</code> for logical datapaths. > </column> > > <column name="table_id"> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
