On Tue, Dec 22, 2015 at 12:17:23PM -0500, Russell Bryant wrote:
> If flake8 is installed, run it at build time.  Similar to most Makefile
> targets, run it once and then only run again if the files change.
> 
> flake8 is set to ignore all error and warning types that currently occur.
> Future patches will remove items from the ignore list as they are
> resolved.
> 
> Signed-off-by: Russell Bryant <russ...@ovn.org>

Would you mind adding a mention of this tool to INSTALL.md, probably
somewhere around where "sparse" is already mentioned?

I'd mark the new pep8-check target "phony" in Makefile.am.

I'd think that the flake8 target would be flake8-check, not pep8-check.

Would there be any value in a FLAKE8_FLAGS variable to supplement
(replace?) the default flags?

Would you mind adding $(AM_V_GEN) to the beginning of the Makefile
command, so that the "make" output is cleaner for those of us who use
the abbreviated output?

That's a lot of complaints but I actually like this, thanks.

Acked-by: Ben Pfaff <b...@ovn.org>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to