On Tue, Jan 05, 2016 at 11:23:24AM -0500, Russell Bryant wrote: > On 01/04/2016 07:23 PM, Ben Pfaff wrote: > > On Tue, Dec 22, 2015 at 12:17:23PM -0500, Russell Bryant wrote: > >> If flake8 is installed, run it at build time. Similar to most Makefile > >> targets, run it once and then only run again if the files change. > >> > >> flake8 is set to ignore all error and warning types that currently occur. > >> Future patches will remove items from the ignore list as they are > >> resolved. > >> > >> Signed-off-by: Russell Bryant <russ...@ovn.org>
> > I'd mark the new pep8-check target "phony" in Makefile.am. > > I didn't mark it as phony because the target actually generates a > "pep8-check" file to make sure flake8 only runs if any Python code has > changed since the last time it ran. > > Let me know if I'm misunderstanding .PHONY or if you have a better > suggestion for accomplishing the goal. You're right, sorry, my mistake. I actually told someone else the same thing about a different target in the same Makefile a while back, you'd think I'd remember my own previous logic. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
