Two notes below, Acked-by: Jarno Rajahalme <ja...@ovn.org>
> On Jan 27, 2016, at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > > Commands like "cat file | a" can be rewritten more cheaply as "a < file". > > Signed-off-by: Ben Pfaff <b...@ovn.org> (snip) > @@ -6697,7 +6697,7 @@ OVS_WAIT_UNTIL([grep "monitor thread created" > ovs-vswitchd.log]) > AT_CHECK([ovs-vsctl set interface p0 bfd:enable=false]) > # check log. > OVS_WAIT_UNTIL([grep "monitor thread terminated" ovs-vswitchd.log]) > -AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp && > mv tmp ovs-vswitchd.log]) > +AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp && > mv tmp ovs-vswitchd.log && ovs-appctl vlog/reopen]) > Maybe this should have been in the previous patch? > # enable cfm on p0. > AT_CHECK([ovs-vsctl set interface p0 cfm_mpid=10]) > @@ -6707,7 +6707,7 @@ OVS_WAIT_UNTIL([grep "monitor thread created" > ovs-vswitchd.log]) > AT_CHECK([ovs-vsctl remove interface p0 cfm_mpid 10]) > # check log. > OVS_WAIT_UNTIL([grep "monitor thread terminated" ovs-vswitchd.log]) > -AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp && > mv tmp ovs-vswitchd.log]) > +AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp && > mv tmp ovs-vswitchd.log && ovs-appctl vlog/reopen]) > Ditto. > # enable both bfd and cfm on p0. > AT_CHECK([ovs-vsctl set interface p0 bfd:enable=true cfm_mpid=10]) > @@ -7115,7 +7115,7 @@ AT_CHECK([ovs-appctl dpif/dump-flows br0 | strip_ufid | > strip_used | sort], [0], > recirc_id(0),in_port(1),eth_type(0x1234), packets:5, bytes:300, used:0.0s, > actions:push_vlan(vid=4,pcp=0),100 > ]) (snip) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
