> On May 6, 2016, at 1:10 PM, Ben Pfaff <b...@ovn.org> wrote: > > static void > nbctl_lport_add(struct ctl_context *ctx) > { > - struct nbrec_logical_port *lport; > + bool may_exist = shash_find(&ctx->options, "--may-exist") != NULL;
For the commands to which you added "--may-exist", it might be nice to update man page. > + > const struct nbrec_logical_switch *lswitch; > - int64_t tag; > + lswitch = lswitch_by_name_or_uuid(ctx, ctx->argv[1], true); > > - lswitch = lswitch_by_name_or_uuid(ctx, ctx->argv[1]); > - if (!lswitch) { > - return; > - } > Not sure if it's on purpose, but you end up with two blank lines here. Acked-by: Justin Pettit <jpet...@ovn.org> --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev