On Sat, May 07, 2016 at 04:10:28PM -0700, Justin Pettit wrote:
>
> > On May 6, 2016, at 1:10 PM, Ben Pfaff <[email protected]> wrote:
> >
> > static void
> > nbctl_lport_add(struct ctl_context *ctx)
> > {
> > - struct nbrec_logical_port *lport;
> > + bool may_exist = shash_find(&ctx->options, "--may-exist") != NULL;
>
> For the commands to which you added "--may-exist", it might be nice to
> update man page.
Oops, somehow the manpage updates leaked into patch 3 instead. Fixed.
> > +
> > const struct nbrec_logical_switch *lswitch;
> > - int64_t tag;
> > + lswitch = lswitch_by_name_or_uuid(ctx, ctx->argv[1], true);
> >
> > - lswitch = lswitch_by_name_or_uuid(ctx, ctx->argv[1]);
> > - if (!lswitch) {
> > - return;
> > - }
> >
>
> Not sure if it's on purpose, but you end up with two blank lines here.
Fixed, thanks.
> Acked-by: Justin Pettit <[email protected]>
Thanks for the review!
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
