On 14 July 2016 at 19:00, Alin Serdean <[email protected]> wrote:
> Thanks for the review! Comments inlined. > > > > Thanks, > > Alin. > > > > *De la:* Guru Shetty [mailto:[email protected]] > *Trimis:* Friday, July 15, 2016 1:27 AM > *Către:* Alin Serdean <[email protected]> > *Cc:* [email protected] > *Subiect:* Re: [ovs-dev] [PATCH v2 1/3] Windows: Local named pipe > implementation > > > > > > > > On 12 July 2016 at 20:32, Alin Serdean <[email protected]> > wrote: > > Currently in the case of command line arguments punix/unix, on Windows > we create a file, write a TCP port number to connect. This is a security > concern. > > This patch adds support for the command line arguments punix/unix trying > to mimic AF_UNIX behind a local named pipe. > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > > > > If I apply this patch, then the compilation fails on Linux. Also, can you > please carefully look at commit cb54a8c57646a1549dcff0c2ad4c2d8b46bc2880 > and commit e3f512b07c11de6b297050bb969fd0d8a07f9357 which added these > features in the first place. Those commits add a lot more than what this > series removes. > > > > [Alin Gabriel Serdean: ] Sorry about the compilation error I will squash > the first two commits. Unless I am missing should I just update the > comments and man pages as well, or there is a part of the code I missed? > There were a couple of function declarations and man page changes missed. I just wanted you take a look at other changes to make sure that they are alright now too. > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
