On 14 July 2016 at 20:42, Guru Shetty <g...@ovn.org> wrote:

>
>
> On 14 July 2016 at 19:57, Alin Serdean <aserd...@cloudbasesolutions.com>
> wrote:
>
>> On 12 July 2016 at 20:32, Alin Serdean <aserd...@cloudbasesolutions.com>
>> wrote:
>>
>> Currently in the case of command line arguments punix/unix, on Windows
>> we create a file, write a TCP port number to connect. This is a security
>> concern.
>>
>> This patch adds support for the command line arguments punix/unix trying
>> to mimic AF_UNIX behind a local named pipe.
>>
>> Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com>
>>
>>
>>
>> If I apply this patch, then the compilation fails on Linux. Also, can you
>> please carefully look at commit cb54a8c57646a1549dcff0c2ad4c2d8b46bc2880
>> and commit e3f512b07c11de6b297050bb969fd0d8a07f9357 which added these
>> features in the first place. Those commits add a lot more than what this
>> series removes.
>>
>>
>>
>> [Alin Gabriel Serdean: ] Sorry about the compilation error I will squash
>> the first two commits. Unless I am missing should I just update the
>> comments and man pages as well, or there is a part of the code I missed?
>>
>> There were a couple of function declarations and man page changes missed.
>> I just wanted you take a look at other changes to make sure that they are
>> alright now too.
>>
>>
>>
>> [Alin Gabriel Serdean: ] I think I’m blind! I still can’t see the
>> function declarations I missed. Can you please point them out?
>>
> You are fine. I think you missed
> https://github.com/openvswitch/ovs/blob/master/lib/stream-provider.h#L195
> (not function declarations)
>
Never mind. I think you still need them.

>
>
>>
>>
>
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to