2010/2/10 Gurkan Erdogdu <cgurkanerdo...@gmail.com>: > Hi Joe, > >>>>Along these lines, what is the general feeling about committing changes >>>>without an associated JIRA issue? > We must not do :) Actually we have to always include JIRA-Id for committing > but we are sometimes lazy. From now on, as a general rule; before committing > some codes, always attach JIRA id if it exists, and if there is no JIRA > create a new one. WDYT?
generally that si fine; MyFaces does the same. But, e.g. changing poms etc doesn't really need that. > >>>>Also I've found the Eclipse formatter you sent a while back to be very >>>>useful for auto-formatting new files. Perhaps we should add a link to > this >>>>from the website for any new developers. > Yes, it is very useful. Otherwise every committer use run its own formatter > rules :) > > Thanks; > > --Gurkan > > 10 Şubat 2010 16:56 tarihinde Joseph Bergmark <bergm...@gmail.com> yazdı: > >> Along these lines, what is the general feeling about committing changes >> without an associated JIRA issue? I've been opening sometimes trivial JIRA >> issues in order to associate them with any commit I do, but I'm not sure if >> this is required or not. >> >> Also I've found the Eclipse formatter you sent a while back to be very >> useful for auto-formatting new files. Perhaps we should add a link to this >> from the website for any new developers. >> >> Sincerely, >> >> Joe >> >> On Wed, Feb 10, 2010 at 12:44 AM, Gurkan Erdogdu <gurkanerdo...@yahoo.com >> >wrote: >> >> > Hello folks; >> > >> > While committing code into our code base, it is good idea to have >> following >> > and obey our formatter rules >> > >> > 1* Remove unused imports >> > 2* Try to get rid of generic warnings >> > 3* Use correct line bracing and tab space >> > 4* Use SVN properties >> > >> > Thanks; >> > >> > --Gurkan >> > >> > >> > >> > ___________________________________________________________________ >> > Yahoo! Türkiye açıldı! http://yahoo.com.tr >> > İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor! >> > >> > > > > -- > Gurkan Erdogdu > http://gurkanerdogdu.blogspot.com > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
