yes, IMO not a stopper! (isn't this already since a while?) (yeah, i have the jboss repos in my default profile (via settings.xml))
-M 2010/3/3 Jean-Louis MONTEIRO <[email protected]>: > Sounds good to me even if i definitely prefer self contained pom (ie. > avoid necessary information in settings.xml). > As it's not a release stopper issue, here is my > > +1 > > JLouis > > 2010/3/3 Gurkan Erdogdu <[email protected]>: >> And also same scenario exists to install from source (setting up some JBoss >> repos on settings.xml). In source version, we just tag the source from >> /trunk. This is also valid for us, committers. If we have not set those >> repos in settings.xml, not compile. >> >> We could add some comments to README on BUILD from source at next release. >> >> --Gurkan >> >> 03 Mart 2010 17:17 tarihinde Gurkan Erdogdu <[email protected]>yazdı: >> >>> >>>Is that acceptable for a milestone release? >>> Samples are given as a source not as a binary. Its the user responsibility >>> to setup correct maven repository in his/her environments. I think that >>> this is not a release stopper issue. >>> >>> Thanks; >>> >>> --Gurkan >>> >>> 2010/3/3 Joseph Bergmark <[email protected]> >>> >>> It looks like you need to add the JBoss repo both for the samples to work >>>> from the binary archives, and for the source archives to build. Is that >>>> acceptable for a milestone release? >>>> >>>> I ran the reservation sample from a seperate machine (that didn't have >>>> javaassist 3.11.0 in my local .m2 already), and I'm not seeing the NPE in >>>> reservation once I added the jboss repositories to the pom.xml. That >>>> problem does appear to have been isolated to my development machine. >>>> >>>> Sincerely, >>>> >>>> Joe >>>> >>>> On Wed, Mar 3, 2010 at 7:03 AM, Jean-Louis MONTEIRO <[email protected] >>>> >wrote: >>>> >>>> > Hey! >>>> > >>>> > As a side note, the LICENCE file contains "Copyright [yyyy] [name of >>>> > copyright owner]". >>>> > Dunno if it's important for a milestone release. >>>> > >>>> > To make samples working, you should add Gurkan's repo and JBoss repo >>>> > cause javassist 3.11.0.GA is not available in central. >>>> > Already discussed that point with Mark. I'll try to push javassist >>>> > 3.11 to central repo. >>>> > >>>> > jsf2sample: missing version in plugin jetty (same for >>>> > conversation-sample - at least). >>>> > >>>> > In my opinion, it'd be great to add a plugin management section in the >>>> > sample parent pom defining jetty plugin version. >>>> > >>>> > Good job guys. >>>> > Jean-Louis >>>> > >>>> > >>>> > >>>> > >>>> > 2010/3/2 Gurkan Erdogdu <[email protected]>: >>>> > > 1* For errors: I have tried from source, binaries and tag versions. >>>> All >>>> > of them have worked. >>>> > > Did the following >>>> > > * Remove ~/.m2/repositories/org/apache/openwebbeans >>>> > > * Add the following to reservation/pom.xml to use staged maven >>>> modules >>>> > > <repositories> >>>> > > <repository> >>>> > > <id>sddfsnapshots.jboss.org</id> >>>> > > >>>> > http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-M4/plugins/<http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-M4/plugins/> >>>> <http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-M4/plugins/> >>>> > > </repository> >>>> > > </repositories> >>>> > > * mvn clean jetty:run -Pjetty >>>> > > * It works >>>> > > >>>> > > Also tried from distribution source version, and install it. >>>> > > Also tried tag version. >>>> > > >>>> > > All of them work in my machine JDK 1.6.0_14, Ubuntu 8.04 - the Hardy >>>> > Heron, Apache Maven 2.2.1 >>>> > > >>>> > > 2* For second, repositories related with Jboss and third parties >>>> > generally setup on settings.xml instead of in pom.xml. Therefore we >>>> remove >>>> > JBoss related repos from pom.xml. But as you said, it is beneficial to >>>> > commen those repositories in README file. We can touch it on next >>>> release. I >>>> > think it is not a negative impact on vote. (Actually this repos are >>>> related >>>> > with TCK packages that are not directly used by users) >>>> > > >>>> > > >>>> > > Thanks; >>>> > > >>>> > > --Gurkan >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > ________________________________ >>>> > > From: Joseph Bergmark <[email protected]> >>>> > > To: [email protected] >>>> > > Sent: Wed, March 3, 2010 12:24:34 AM >>>> > > Subject: Re: [VOTE] Release OpenWebBeans-M4 >>>> > > >>>> > > I was able to verify the signature of the source and binary files. >>>> > However >>>> > > I've run into a couple of problems >>>> > > >>>> > > 1) I added the M4 staging repo to the pom.xml of a couple of the >>>> samples >>>> > > from the binary tar.gz and ran them to ensure they worked as expected. >>>> > Both >>>> > > guess and jsf2sample worked fine, however when I tried to follow the >>>> "Not >>>> > a >>>> > > registered! Register here...< >>>> > http://localhost:8080/reservation/register.jsf>" >>>> > > in the reservation sample I hit a NPE: >>>> > > >>>> > > Caused by: java.lang.NullPointerException >>>> > > at >>>> > org.apache.webbeans.reservation.util.LogUtil.getLogger(LogUtil.java:33) >>>> > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>> > > at >>>> > >>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48) >>>> > > at >>>> > >>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37) >>>> > > at java.lang.reflect.Method.invoke(Method.java:600) >>>> > > at >>>> > >>>> org.apache.webbeans.inject.InjectableMethods.doInjection(InjectableMethods.java:117) >>>> > > at >>>> > >>>> org.apache.webbeans.component.ProducerMethodBean.createDefaultInstance(ProducerMethodBean.java:184) >>>> > > at >>>> > >>>> org.apache.webbeans.component.ProducerMethodBean.createInstance(ProducerMethodBean.java:151) >>>> > > at >>>> > >>>> org.apache.webbeans.component.AbstractOwbBean.create(AbstractOwbBean.java:153) >>>> > > at >>>> > >>>> org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:65) >>>> > > at >>>> > >>>> org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:151) >>>> > > at >>>> > >>>> org.apache.webbeans.container.BeanManagerImpl.getReference(BeanManagerImpl.java:784) >>>> > > >>>> > > I did a bit of debugging, and it appears the injected InjectionPoint >>>> is >>>> > > null. >>>> > > >>>> > > Gurkan is not able to reproduce this error, so it is possibly >>>> something >>>> > > specific to my environment. Is anyone else seeing this problem? I'll >>>> > try >>>> > > it on another machine later tonight. >>>> > > >>>> > > 2) I then tried to build from the source zip, and hit a missing >>>> > dependency >>>> > > executing "mvn clean install" from the top level openwebbeans >>>> directory: >>>> > > Missing: >>>> > > ---------- >>>> > > 1) org.jboss.test-harness:jboss-test-harness-api:jar:1.1.0-CR5 >>>> > > >>>> > > It appears this comes from the 299 TCK: >>>> > > >>>> > > Path to dependency: >>>> > > 1) org.apache.openwebbeans:openwebbeans-porting:jar:1.0.0-M4 >>>> > > 2) org.jboss.jsr299.tck:jsr299-tck-api:jar:1.0.1-Final >>>> > > 3) org.jboss.test-harness:jboss-test-harness-api:jar:1.1.0-CR5 >>>> > > >>>> > > Should we document that JBoss repositories need to be added to your >>>> local >>>> > > settings for the source zip to build? I know we removed some >>>> > repositories >>>> > > from the top level pom.xml. >>>> > > >>>> > > Sincerely, >>>> > > >>>> > > Joe >>>> > > >>>> > > On Tue, Mar 2, 2010 at 3:38 AM, Matthias Wessendorf < >>>> [email protected] >>>> > >wrote: >>>> > > >>>> > >> +1 >>>> > >> >>>> > >> On Mon, Mar 1, 2010 at 10:01 PM, Mark Struberg <[email protected]> >>>> > wrote: >>>> > >> > +1 from me too. >>>> > >> > >>>> > >> > >>>> > >> > PS: @OWB-289: since I now know _what_ the problem is, it is really >>>> > easy >>>> > >> to do a workaround by moving my other producerMethod to an own class. >>>> > The >>>> > >> problem was that this is part of a pretty complicated usecase, and I >>>> > only >>>> > >> did see my program fail randomly, which made me frankly said a bit >>>> > nervous >>>> > >> ;) >>>> > >> > >>>> > >> > LieGrue, >>>> > >> > strub >>>> > >> > >>>> > >> > --- Gurkan Erdogdu <[email protected]> schrieb am Mo, >>>> 1.3.2010: >>>> > >> > >>>> > >> >> Von: Gurkan Erdogdu <[email protected]> >>>> > >> >> Betreff: [VOTE] Release OpenWebBeans-M4 >>>> > >> >> An: [email protected] >>>> > >> >> Datum: Montag, 1. März, 2010 21:52 Uhr >>>> > >> >> Hi; >>>> > >> >> >>>> > >> >> Finally release time :) >>>> > >> >> >>>> > >> >> This is the OpenWebBeans M4 release [VOTE] process. >>>> > >> >> >>>> > >> >> I've staged the releases artifacts here: >>>> > >> >> >>>> > >> >> Plugins repository >>>> > >> >> -------------------------- >>>> > >> >> >>>> > >> >>>> > >>>> http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-M4/plugins/org/apache/openwebbeans<http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-M4/plugins/org/apache/openwebbeans> >>>> < >>>> http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-M4/plugins/org/apache/openwebbeans >>>> > >>>> > < >>>> > >>>> http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-M4/plugins/org/apache/openwebbeans >>>> > > >>>> > >> >> >>>> > >> >> Distribution content >>>> > >> >> ---------------------------- >>>> > >> >> >>>> > >> >>>> > >>>> http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-M4/distribution/org/apache/openwebbeans/apache-openwebbeans/1.0.0-M4/<http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-M4/distribution/org/apache/openwebbeans/apache-openwebbeans/1.0.0-M4/> >>>> < >>>> http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-M4/distribution/org/apache/openwebbeans/apache-openwebbeans/1.0.0-M4/ >>>> > >>>> > < >>>> > >>>> http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-M4/distribution/org/apache/openwebbeans/apache-openwebbeans/1.0.0-M4/ >>>> > > >>>> > >> >> >>>> > >> >> SVN Tag (Revision: 917708) >>>> > >> >> ---------------------------- >>>> > >> >> http://svn.apache.org/repos/asf/openwebbeans/tags/1.0.0-M4/ >>>> > >> >> >>>> > >> >> This is the README file for the M4 release for quick >>>> > >> >> review: >>>> > >> >> >>>> > >> >> >>>> > >> >>>> > >>>> http://svn.apache.org/repos/asf/openwebbeans/tags/1.0.0-M4/readme/README_M4.txt >>>> > >> >> >>>> > >> >> Please verify that this release package is correct and vote >>>> > >> >> for the >>>> > >> >> motion to publish this as a OpenWebBeans M4 release. >>>> > >> >> All votes are welcome and will be counted. >>>> > >> >> >>>> > >> >> VOTE is open for 72 hours >>>> > >> >> >>>> > >> >> This is my +1 >>>> > >> >> >>>> > >> >> Thanks; >>>> > >> >> >>>> > >> >> /Gurkan >>>> > >> >> >>>> > >> >> >>>> > >> >> >>>> > >> >> >>>> ___________________________________________________________________ >>>> > >> >> Yahoo! Türkiye açıldı! http://yahoo.com.tr >>>> > >> >> İnternet üzerindeki en iyi içeriği Yahoo! Türkiye >>>> > >> >> sizlere sunuyor! >>>> > >> > >>>> > >> > __________________________________________________ >>>> > >> > Do You Yahoo!? >>>> > >> > Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden >>>> > Schutz >>>> > >> gegen Massenmails. >>>> > >> > http://mail.yahoo.com >>>> > >> > >>>> > >> >>>> > >> >>>> > >> >>>> > >> -- >>>> > >> Matthias Wessendorf >>>> > >> >>>> > >> blog: http://matthiaswessendorf.wordpress.com/ >>>> > >> sessions: http://www.slideshare.net/mwessendorf >>>> > >> twitter: http://twitter.com/mwessendorf >>>> > >> >>>> > > >>>> > > >>>> > > >>>> > > >>>> ___________________________________________________________________ >>>> > > Yahoo! Türkiye açıldı! http://yahoo.com.tr >>>> > > İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor! >>>> > >>>> >>> >>> >>> >>> -- >>> Gurkan Erdogdu >>> http://gurkanerdogdu.blogspot.com >>> >> >> >> >> -- >> Gurkan Erdogdu >> http://gurkanerdogdu.blogspot.com >> > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
