Thanks Daisy awesome progress +1 I'm OK adding headers to all files including test files. Not a strong opinion, might be easier when creating a bot/automation to scan for headers everything has a header easy to remember rule.
One to double check if the *.md file having the header will be fine for the jekyll webstite [1] that it doesn't brake and we just need to modify some config or the deployment script [1] https://github.com/apache/incubator-openwhisk-website -- Carlos On Tue, Mar 6, 2018 at 9:15 AM Ying Chun Guo <guoyi...@cn.ibm.com> wrote: > Hi, team > > I'd like to update the work of checking license headers. Two related PRs > are: > https://github.com/apache/incubator-openwhisk-release/pull/53 > https://github.com/apache/incubator-openwhisk-release/pull/52 > > Based on the previous discussion, we will exclude below type of files from > license header verification because of little creativity: > - Json files > - Gradle setting files > - Configuration files prefixed with dot > - Template files used in OpenWhisk installation > > And we will use short form of header to minified OpenWhisk action source > files in order to get better performance. > > Now we are able to support approved ASF short format headers during RAT > tool scanning. But we still have 460+ files without approved license > headers in the 12 main repos. Most of these files are: > - *.md files > - test actions and test yaml files > - *.sh files, installation scripts > - docker files > - ansible yaml files > > Later, we have to add ASF headers to those files before we make the > official release. If you have different opinions with adding headers on top > of these files, please discuss in the mailing list. Thank you. > > Best regards > Ying Chun Guo (Daisy) > >
