You closed the PR (I have the email somewhere) with a comment "move in the 
runtime" and I removed the repo as it was only holding that change.

I just pushed again the code on github. It is here:

https://github.com/sciabarracom/incubator-openwhisk

I do not think it is mergeable with the current repo.

The significant files are just:

tests/src/test/scala/actionContainers/ActionLoopContainerTests.scala
tests/src/test/scala/actionContainers/ActionLoopGoContainerTests.scala
tests/src/test/scala/actionContainers/ActionLoopSwiftContainerTests.scala
tests/src/test/scala/actionContainers/ResourceHelpers.scala

However,  since I was requested to move in the repo, I fixed my original, "cram 
based" test.

https://github.com/apache/incubator-openwhisk-runtime-go/pull/43

I do not really see a good fit to add a lot of scala code to a go repo just to 
run a bunch of simple tests while I already have those tests running with Cram 
(https://pypi.org/project/cram/).  Those are really just integration tests.

Most of the tests are actually already rewritten in Go and integrated in the 
travis build (it was hard enough as the timing in Travis are different than on 
a mac).

-- 
  Michele Sciabarra
  [email protected]

----- Original message -----
From: Rodric Rabbah <[email protected]>
To: [email protected]
Subject: Re: Where to contribute examples for Golang?
Date: Mon, 23 Jul 2018 15:53:28 +0000

> I contributed ScalaTest tests for my runtime  to the main repository, as
it was requested, and my PR was closed because now they should be moved ...
in the runtime.

Do you have a link for the PR? This query doesn't return anything
https://github.com/apache/incubator-openwhisk/pulls?utf8=%E2%9C%93&q=is%3Apr+from%3Asciabarra
maybe I have your github id wrong. I'm happy to take a look and help.

-r

Reply via email to