Thanks for the update - will review the PR again. On Mon, Nov 26, 2018 at 9:26 AM Christian Bickel <m...@cbickel.de> wrote:
> Hi Rodric, > > thanks a lot for your feedback. I changed my PR to use the quota instead of > switching it off completely. > > Now the controller checks, how many activations have been written in the > current minute. The remaining quota is passed on. On trying to save an > activation (of a trigger, a sequence or an activation) this quota is > checked and only saved, if it is above 0. > > Greetings > Christian > > Am Mi., 24. Okt. 2018 um 17:38 Uhr schrieb Rodric Rabbah <rod...@gmail.com > >: > > > Thanks for the additional information Christian - I took a look at the PR > > and added a few comments. I think you can approach this as another quota > > (number of activations stored per minute or per hour) and setting the > quota > > to 0 would disable all stores. > > > > I also don't like the way this was done in the artifact store - it's a > fast > > hack, but bleeds through the abstractions. We should not do this in my > > opinion. At the least, the invoker (and controller) wasted effort and > held > > up resources gathering logs etc only to be thrown away later. > > > > -r > > >
