Nice work - I took an initial look and will go through the PRs and try them out on knative.
-r On Mon, Apr 15, 2019 at 12:47 PM Matt Rutkowski <[email protected]> wrote: > Thanks Priti for your excellent work getting the code under devtools repo. > working with Gradle for all Node versions. It is indeed exciting to be at > the point where we believe the code is ready for public review. > > This PR is what we have been discussing and demoing over the last 2 months > which showcases the use of a platform factory that can, via the build > process, either create the traditional OpenWhisk-native implementation > which provides the same, identical code path (i.e., init/run endpoints) we > have used since forever or create a Knative impl. which supports supports a > single endpoint and furthermore includes HTTP request pre-processing and > response post-processing to provide an equivalent function experience where > possible. > > -MR > > PS thank for all the test cases that are in a sister PR as well. > > On 2019/04/10 20:58:34, "Priti Desai" <[email protected]> wrote: > > Hi Whiskers, > > > > I have created a PR under NodeJS runtime repo with changes to run the > > NodeJS OpenWhisk actions on Knative. > > > > Please refer to the PR here: > > > > https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119 > > > > If you are running the NodeJS runtime on OpenWhisk, please note that > there > > are NO CHANGES introduced at all. We have added an ability to run on > > Knative without making any changes while running on OpenWhisk. > > > > I have created two more PRs for documentation and tests: > > > > documentation - > > https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/120 > > test - > > https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/121 > > > > Please feel free to review/comment on respective PRs. > > > > Cheers > > Priti > > > > > > >
