Thanks Christophe for the contribution. The specific change is question is part of the test suite we run for all runtimes. The test checks the what values are available in the runtime context. Since there’s a new value (action version) now being checked, I see two options:
Make the change as is and accept the PR and then patch up all the runtimes (the change is trivial but has to be done for all the runtime repos). Alternatively, make the check for the additional context variable optional which won’t break any of the runtime tests and once all the runtimes are updated, then we can make it mandatory. I favor the first approach in this case but others may differ. The runtimes themselves do not need to change, it is only one test that needs to adapt per runtime. -r > On Dec 3, 2019, at 4:56 AM, Christophe Jelger <jel...@adobe.com.invalid> > wrote: > > Hello, > > I just joined the dev list after opened > https://github.com/apache/openwhisk/pull/4761 : it adds OW_ACTION_VERSION to > the execution environment. > > I was asked by Rodric to send this email to the list because this change will > require extra changes in the runtime repos for tests (see his comment in the > PR). > Since I just joined the list and have until now only been an active user of > OpenWhisk, I don’t know what the process is to do that next. Any hint is > appreciated. > > BR, > Christophe > -- > Christophe Jelger | AEM Commerce Developer > Adobe Research Schweiz AG > +41 (0)61 226 5792 >
